Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #153

Merged
merged 6 commits into from
Sep 10, 2021
Merged

3 ➡️ 4 #153

merged 6 commits into from
Sep 10, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-sensors3 to ign-sensors4

Branch comparison: ign-sensors4...ign-sensors3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Aug 26, 2021
@ahcorde ahcorde added the needs upstream release Blocked by a release of an upstream library label Aug 27, 2021
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some issues, but I think it requires some releases. msgs6 ?

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Aug 30, 2021
7 tasks
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Sep 1, 2021
@chapulina chapulina mentioned this pull request Sep 8, 2021
7 tasks
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
chapulina added a commit that referenced this pull request Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #153 (c0f9ecf) into ign-sensors4 (f8b09dc) will increase coverage by 0.35%.
The diff coverage is 87.32%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors4     #153      +/-   ##
================================================
+ Coverage         76.16%   76.52%   +0.35%     
================================================
  Files                23       23              
  Lines              2396     2458      +62     
================================================
+ Hits               1825     1881      +56     
- Misses              571      577       +6     
Impacted Files Coverage Δ
src/Sensor.cc 85.97% <79.48%> (-2.03%) ⬇️
src/CameraSensor.cc 73.89% <83.33%> (+0.53%) ⬆️
src/AirPressureSensor.cc 83.78% <100.00%> (+0.45%) ⬆️
src/AltimeterSensor.cc 86.36% <100.00%> (+0.31%) ⬆️
src/DepthCameraSensor.cc 73.77% <100.00%> (+0.43%) ⬆️
src/GpuLidarSensor.cc 87.26% <100.00%> (+0.16%) ⬆️
src/ImuSensor.cc 89.28% <100.00%> (+0.19%) ⬆️
src/Lidar.cc 70.98% <100.00%> (+0.15%) ⬆️
src/LogicalCameraSensor.cc 87.50% <100.00%> (+0.35%) ⬆️
src/MagnetometerSensor.cc 86.51% <100.00%> (+0.30%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b09dc...c0f9ecf. Read the comment docs.

Also fix deprecation warning.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 9f03bcc into ign-sensors4 Sep 10, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch September 10, 2021 22:26
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants