Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Namespace Migration : gz-sensors #226

Merged
merged 24 commits into from
May 29, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels May 18, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

include/gz/sensors/config.hh.in Outdated Show resolved Hide resolved
include/gz/sensors/config.hh.in Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 5 times, most recently from 1a9f2de to f92c7e5 Compare May 20, 2022 10:27
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #226 (1c52479) into main (d60d832) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits           12       12           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60d832...1c52479. Read the comment docs.

@methylDragon methylDragon merged commit 55c5666 into main May 29, 2022
@methylDragon methylDragon deleted the namespace_migration branch May 29, 2022 02:23
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants