-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ign common plugin loader with ign-plugin #38
Changes from 6 commits
a027783
50feecc
25be8d7
21badd7
b78594d
c5d0cdb
f3dfca3
a0a0e65
dd97599
5b4b7a9
b69410c
6da3f22
f233366
6e5c4e9
161765c
acc0084
893b79c
0a6de53
74f3c71
947361e
0a03653
151415b
69ba811
c15ad7c
7448fbe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,8 @@ | |
#include <ignition/common/Profiler.hh> | ||
#include <ignition/transport/Node.hh> | ||
|
||
#include <ignition/plugin/Register.hh> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this include needed at every sensor? Shouldn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According with the migration guide https://github.com/ignitionrobotics/ign-plugin/blob/94482af3e9b2cc1cbb7c2dbeb2c7846f8283f0f6/MIGRATION.md#registering-a-plugin I added this header for registering plugins. All sensors are individual components that why I need to use ``/usr/bin/ld: ../lib/libignition-sensors4-imu.so.4.0.0~pre1: undefined reference `IgnitionPluginHook'
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I see. I mean, we'd still be including that header, just indirectly. The way
And it probably needs to link against There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chapulina, I was trying your suggestion but I'm not able to compile the code. I was having a look to other packages that make use of ignition-plugin and the approach it's similar to the one that I used here. For example: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I think the key difference here is that the Does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All plugin are using the MACRO but it's hidden under this other one IGN_SENSORS_REGISTER_SENSOR There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @chapulina I can remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
#include "ignition/sensors/GaussianNoiseModel.hh" | ||
#include "ignition/sensors/Noise.hh" | ||
#include "ignition/sensors/SensorTypes.hh" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No other plugins have
RegisterMore
on their headers, can it be removed here?