👩🌾 Prevent segfaults on test failures, make tests verbose #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-sensors3 #56 +/- ##
================================================
- Coverage 77.61% 77.54% -0.07%
================================================
Files 23 23
Lines 2296 2298 +2
================================================
Hits 1782 1782
- Misses 514 516 +2
Continue to review full report at Codecov.
|
iche033
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help shed some light into #4 .
ASSERT_NE(nullptr...)to prevent test segfaultsIt looks like the sensor is created correctly, but the problem happens when casting the sensor to the desired type. Maybe there's a mismatch between the types from the core library and the sensor's shared library? I vaguely remember @ahcorde having a solution for this while working on #38, but I don't know if that solution works for Citadel.
CC @scpeters , who was looking into #4.