Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Prevent segfaults on test failures, make tests verbose #56

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

chapulina
Copy link
Contributor

This should help shed some light into #4 .

  • Use ASSERT_NE(nullptr...) to prevent test segfaults
  • Make all tests verbose to help debug issues

It looks like the sensor is created correctly, but the problem happens when casting the sensor to the desired type. Maybe there's a mismatch between the types from the core library and the sensor's shared library? I vaguely remember @ahcorde having a solution for this while working on #38, but I don't know if that solution works for Citadel.

CC @scpeters , who was looking into #4.

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #56 into ign-sensors3 will decrease coverage by 0.06%.
The diff coverage is 40.00%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-sensors3      #56      +/-   ##
================================================
- Coverage         77.61%   77.54%   -0.07%     
================================================
  Files                23       23              
  Lines              2296     2298       +2     
================================================
  Hits               1782     1782              
- Misses              514      516       +2     
Impacted Files Coverage Δ
include/ignition/sensors/Manager.hh 75.00% <40.00%> (-15.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277c18f...ea14014. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why the cast fails.. but code looks good to me

@chapulina chapulina merged commit 85668a2 into ign-sensors3 Nov 6, 2020
@chapulina chapulina deleted the chapulina/tests branch November 6, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants