Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visualize collisions to support 1.8 composition #767

Closed
jennuine opened this issue Apr 14, 2021 · 0 comments · Fixed by #823
Closed

Update visualize collisions to support 1.8 composition #767

jennuine opened this issue Apr 14, 2021 · 0 comments · Fixed by #823
Assignees
Labels
bug Something isn't working 🏢 edifice Ignition Edifice enhancement New feature or request 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)

Comments

@jennuine
Copy link
Contributor

jennuine commented Apr 14, 2021

In Citadel & Dome, which uses SDFormat 1.7, when a sdf model contained collisions, then right-clicking to View > Collisions would display all collisions of the model in orange. In Edifice, this no longer works correctly if the model has nested models.

The current implementation (see #531 for details) checks links of the model for collision entities but assumes that links will be direct children of the model entity. To support SDFormat 1.8, the implementation needs to consider nested models.

To test this, run ign gazebo nested_model.sdf, then in the entity tree right-click model_00 > View > Collisions and only the sphere will be highlighted in orange.

@jennuine jennuine added enhancement New feature or request GUI Gazebo's graphical interface (not pure Ignition GUI) 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Apr 14, 2021
@jennuine jennuine self-assigned this Apr 14, 2021
@jennuine jennuine added the bug Something isn't working label May 4, 2021
@ahcorde ahcorde mentioned this issue May 17, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏢 edifice Ignition Edifice enhancement New feature or request 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant