Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireframe mode #816

Merged
merged 5 commits into from
May 17, 2021
Merged

Wireframe mode #816

merged 5 commits into from
May 17, 2021

Conversation

atharva-18
Copy link
Contributor

@atharva-18 atharva-18 commented May 13, 2021

🎉 New feature

Summary

View models and links as wireframes, similar to Gazebo Classic.
wireframe_ign_f

Nested model
wireframe_nested_model

Test it

Test it by running ign gazebo -v 4 examples/worlds/nested_model.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #816 (31c02c0) into main (d19dda1) will decrease coverage by 0.41%.
The diff coverage is 11.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   65.34%   64.92%   -0.42%     
==========================================
  Files         240      240              
  Lines       17602    17727     +125     
==========================================
+ Hits        11502    11510       +8     
- Misses       6100     6217     +117     
Impacted Files Coverage Δ
include/ignition/gazebo/rendering/RenderUtil.hh 100.00% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.hh 66.66% <ø> (ø)
src/rendering/RenderUtil.cc 39.21% <9.57%> (-2.94%) ⬇️
src/gui/plugins/scene3d/Scene3D.cc 9.46% <15.38%> (+0.09%) ⬆️
src/gui/plugins/modules/EntityContextMenu.cc 19.29% <20.00%> (+0.06%) ⬆️
src/SimulationRunner.cc 92.73% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19dda1...31c02c0. Read the comment docs.

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering labels May 13, 2021
Signed-off-by: Atharva Pusalkar <[email protected]>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a style comment

}
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Signed-off-by: Atharva Pusalkar <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented May 17, 2021

@atharva-18 it seems that you were able to make it work with nested models. Do you mind to have a look to this issue? #767 . Collision visualization is not working right now with nested model.

@ahcorde ahcorde merged commit c2a4a40 into gazebosim:main May 17, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/google-summer-of-code-2021-new-gui-widgets-in-ignition-gazebo/1081/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants