-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed IMU system plugin #1043
Fixed IMU system plugin #1043
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1043 +/- ##
===============================================
+ Coverage 77.56% 77.83% +0.27%
===============================================
Files 208 221 +13
Lines 11385 12694 +1309
===============================================
+ Hits 8831 9881 +1050
- Misses 2554 2813 +259
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach. In general, we may need to do this for most systems, especially when we make it easier for users to insert systems at runtime (#190)
Signed-off-by: ahcorde <[email protected]>
…tics/ign-gazebo into ahcorde/fix/sensors
Signed-off-by: ahcorde [email protected]
🦟 Bug fix
While I was developing
ign_ros2_control
I found an issue which is related with adding new model, for example, usingign_ros
to add a URDF.The IMU system plugin is added after the IMU is in the scene which means
_ecm.EachNew
is was called and IMU will be added to the plugin. To fix this I used a similar approach that you can find inRenderUtils.cc
For this reason I used
_ecm.Each
in the first iteration and then we should stick with the current behaviour.I think this should be extended to the other sensor plugins.
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge