Add Ubuntu Jammy CI #1418
Add Ubuntu Jammy CI #1418
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1418 +/- ##
===============================================
+ Coverage 63.36% 63.49% +0.13%
===============================================
Files 306 307 +1
Lines 24715 24771 +56
===============================================
+ Hits 15660 15729 +69
+ Misses 9055 9042 -13
Continue to review full report at Codecov.
|
|
Ouch, python 3.10 hits us, @j-rivero . Not sure you've seen this yet |
I did not see it. I'll fix it. |
I think that we were affected by the python 3.10 transition done in Jammy during the last month. Our ign-math6 package is coming from February and they changed the version. I'm going to bump the revision to just build the same source code again. That should make it. |
I've released 6.10.0-100 and that fixed the problem. CI is still failing, now because doxygen segfaults. I'm going to look at it. |
Signed-off-by: Louise Poubel <[email protected]>
|
Two things on my mind to stop using doxygen unconditionally:
For the second, a simple patch could be enough: diff --git a/CMakeLists.txt b/CMakeLists.txt
index 13443e62..6ac33f1a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -225,26 +225,26 @@ endif()
configure_file(${CMAKE_SOURCE_DIR}/api.md.in ${CMAKE_BINARY_DIR}/api.md)
configure_file(${CMAKE_SOURCE_DIR}/tutorials.md.in ${CMAKE_BINARY_DIR}/tutorials.md)
-# disable doxygen on macOS due to issues with doxygen 1.9.0
-# there is an unreleased fix; revert this when 1.9.1 is released
-# https://github.com/ignitionrobotics/ign-gazebo/issues/520
-if (NOT APPLE)
- ign_create_docs(
- API_MAINPAGE_MD "${CMAKE_BINARY_DIR}/api.md"
- TUTORIALS_MAINPAGE_MD "${CMAKE_BINARY_DIR}/tutorials.md"
- ADDITIONAL_INPUT_DIRS "${CMAKE_SOURCE_DIR}/src/systems ${CMAKE_SOURCE_DIR}/src/gui/plugins"
- IMAGE_PATH_DIRS "${CMAKE_SOURCE_DIR}/tutorials/files"
- TAGFILES
- "${IGNITION-MATH_DOXYGEN_TAGFILE} = ${IGNITION-MATH_API_URL}"
- "${IGNITION-MSGS_DOXYGEN_TAGFILE} = ${IGNITION-MSGS_API_URL}"
- "${IGNITION-PHYSICS_DOXYGEN_TAGFILE} = ${IGNITION-PHYSICS_API_URL}"
- "${IGNITION-PLUGIN_DOXYGEN_TAGFILE} = ${IGNITION-PLUGIN_API_URL}"
- "${IGNITION-TRANSPORT_DOXYGEN_TAGFILE} = ${IGNITION-TRANSPORT_API_URL}"
- "${IGNITION-SENSORS_DOXYGEN_TAGFILE} = ${IGNITION-SENSORS_API_URL}"
- "${IGNITION-COMMON_DOXYGEN_TAGFILE} = ${IGNITION-COMMON_API_URL}"
- )
-endif()
-
if(TARGET doc)
+ # disable doxygen on macOS due to issues with doxygen 1.9.0
+ # there is an unreleased fix; revert this when 1.9.1 is released
+ # https://github.com/ignitionrobotics/ign-gazebo/issues/520
+ if (NOT APPLE)
+ ign_create_docs(
+ API_MAINPAGE_MD "${CMAKE_BINARY_DIR}/api.md"
+ TUTORIALS_MAINPAGE_MD "${CMAKE_BINARY_DIR}/tutorials.md"
+ ADDITIONAL_INPUT_DIRS "${CMAKE_SOURCE_DIR}/src/systems ${CMAKE_SOURCE_DIR}/src/gui/plugins"
+ IMAGE_PATH_DIRS "${CMAKE_SOURCE_DIR}/tutorials/files"
+ TAGFILES
+ "${IGNITION-MATH_DOXYGEN_TAGFILE} = ${IGNITION-MATH_API_URL}"
+ "${IGNITION-MSGS_DOXYGEN_TAGFILE} = ${IGNITION-MSGS_API_URL}"
+ "${IGNITION-PHYSICS_DOXYGEN_TAGFILE} = ${IGNITION-PHYSICS_API_URL}"
+ "${IGNITION-PLUGIN_DOXYGEN_TAGFILE} = ${IGNITION-PLUGIN_API_URL}"
+ "${IGNITION-TRANSPORT_DOXYGEN_TAGFILE} = ${IGNITION-TRANSPORT_API_URL}"
+ "${IGNITION-SENSORS_DOXYGEN_TAGFILE} = ${IGNITION-SENSORS_API_URL}"
+ "${IGNITION-COMMON_DOXYGEN_TAGFILE} = ${IGNITION-COMMON_API_URL}"
+ )
+ endif()
+
file(COPY ${CMAKE_SOURCE_DIR}/tutorials/files/ DESTINATION ${CMAKE_BINARY_DIR}/doxygen/html/files/)
endif()
|
I think it has never come up before. I'm ok with your proposal. It would be interesting to do it from |
|
Good news is that CI for Jammy is as good as Bionic and Focal now 🙂 A bit flaky 🙃 |
Signed-off-by: Louise Poubel <[email protected]>
I'm pretty sure that all of our packages do, which is why I added this PR previously: gazebosim/gz-cmake#144 |
|
We add the |
|
Ah I didn't remember that option, @mjcarroll . Maybe we can just use that on the action then. That should be easier than changing |
Ah thanks for the reminder. It could be somehow an intrusive change, maybe we target it on by default on ign-cmake3 but with that feature in place we call it ready to be used with ign-cmake2 like in this case. Added to the roadmap in gazebosim/gz-cmake#228
+1 . |
Signed-off-by: Louise Poubel <[email protected]>
|
@j-rivero , isn't 4e36f6e redundant as of gazebo-tooling/action-gz-ci#51? |
It is. Both are correct I would say. |
Signed-off-by: Louise Poubel <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1 |
🎉 New feature
Summary
I'm debugging Gazebo on Jammy from source and the changes inpackages.aptwere needed to install the correct dependencies, so I went ahead and opened the PR.This is ready for review!
Test it
Eventually Jammy CI should come back green.Jammy CI comes back green sometimes, but it's flaky other times. Just like Bionic and Focal.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸