Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use versioned svg file #1430

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Use versioned svg file #1430

merged 1 commit into from
Apr 8, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Apr 7, 2022

@j-rivero
Use versioned svg file
2137caf 
To avoid conflicts between different major versions, add the major
version to the svg filename.
@j-rivero j-rivero requested a review from chapulina as a code owner April 7, 2022 21:51
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 7, 2022
@j-rivero j-rivero mentioned this pull request Apr 7, 2022
Merged
@codecov
Copy link

codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #1430 (9ce8cc0) into ign-gazebo3 (2f7bd7e) will not change coverage.
The diff coverage is n/a.

❗ Current head 9ce8cc0 differs from pull request most recent head 2137caf. Consider uploading reports for the commit 2137caf to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo3    #1430   +/-   ##
============================================
  Coverage        77.88%   77.88%           
============================================
  Files              250      250           
  Lines            14378    14378           
============================================
  Hits             11198    11198           
  Misses            3180     3180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7bd7e...2137caf. Read the comment docs.

@chapulina
Copy link
Contributor

It looks like the commit isn't signed 🔍

@j-rivero j-rivero merged commit 97a87c3 into ign-gazebo3 Apr 8, 2022
@j-rivero j-rivero deleted the ign-gazebo3_svg_versioned branch April 8, 2022 16:10
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-rivero @chapulina @osrf-triage