Ign pkg_create #1582
Ign pkg_create #1582
Conversation
Signed-off-by: Harsh Mahesheka <[email protected]>
Signed-off-by: Harsh Mahesheka <[email protected]>
| @@ -0,0 +1,17 @@ | |||
| //This is a sample code showing how an ignition executable works | |||
There was a problem hiding this comment.
Add license?
| //This is a sample code showing how an ignition executable works | |
| // This is a sample code showing how an Gazebo simulator executable works |
There was a problem hiding this comment.
Should I add the license to CMakeLists.txt and the package.xml file I am creating as well? But that would mean anyone using this command will have licensed code to begin with
Signed-off-by: Harsh Mahesheka <[email protected]>
src/cmd/cmdpkg_create.rb.in
Outdated
| opts.on('-e [arg]', '--export_type [arg]', String, 'Export type between colcon or plain-camke') do |e| | ||
| options['export_type'] = e | ||
| end | ||
| opts.on('-d','--standard_dependecies', String, 'Package depends on standard ign packages') do |
There was a problem hiding this comment.
What are standard dependencies? Perhaps it'd be better to name dependencies individually.
You could have a --all-gz-libs to have it depend on all dependencies.
There was a problem hiding this comment.
Ok, I will change the name to all-ign-libs.
There was a problem hiding this comment.
I have changed it to --ign_dependencies because I am not including all ign packages as some of them are unnecessary
| puts usage | ||
| exit | ||
| end | ||
| opts.on('-n [arg]', '--name [arg]', String, 'Name of new package') do |n| |
There was a problem hiding this comment.
Include author and license as options as well.
There was a problem hiding this comment.
So, that information will be used when using ament cmake. Will that be ok?
| @@ -1642,4 +1642,4 @@ TEST_F(LogSystemTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(LogTopics)) | |||
| this->RemoveLogsDir(); | |||
| this->CreateLogsDir(); | |||
| #endif | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I think you need to add a newline to make git happy.
There was a problem hiding this comment.
It's the exact same file,I don't know why git is showing changes
| point2.set_z(std::rand()); | ||
| std::cout << "Random_point1:\n" << point1.DebugString() << std::endl; | ||
| std::cout << "Random_point2:\n" << point2.DebugString() << std::endl; | ||
| return 0; |
There was a problem hiding this comment.
Knit: New line at end of file. Might be more worthwhile to spawn a simulator like we do in unit tests to make the example more interesting
There was a problem hiding this comment.
The idea was to keep the example simple and easy to replicate.What do you think?
Signed-off-by: Harsh Mahesheka <[email protected]>
Signed-off-by: Harsh Mahesheka <[email protected]>
|
Also, https://raw.githubusercontent.com/ignition-tooling/gazebodistro/master/collection-fortress.yaml has gz packages names instead of ign.I am confused, shouldn't fortress have ign name? |
|
🎉 New feature
Depends on gazebosim/gz-cmake#262
Summary
This pull request is regarding my GSoC project which you can visit here . The idea is to create an ignition subcommand that can create a template ignition package based on the user's demands. You can see currently supported options here. Currently in the advanced package option a sample world, model, executable and plugin is made with code to install it.
Would love everyone's review on how to shape it better for users!
Test it
Build this repo with its dependencies and run
ign pkg_create --helpto see various options.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.