Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-sim #1589

Merged
merged 2 commits into from
Jul 19, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-sim #1589

merged 2 commits into from
Jul 19, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Jul 12, 2022 •
edited
Loading

See: gazebo-tooling/release-tools#765

CAN BE SQUASH MERGED!!

@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch 2 times, most recently from a4d9731 to 7a26520 Compare July 12, 2022 20:59
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@chapulina chapulina mentioned this pull request Jul 13, 2022
Merged
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 7a26520 to 9c7d597 Compare July 13, 2022 08:51
@chapulina chapulina added 🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. labels Jul 13, 2022
chapulina
chapulina suggested changes Jul 13, 2022
View reviewed changes
examples/worlds/lift_drag.sdf Outdated Show resolved Hide resolved
examples/worlds/lift_drag_battery.sdf Outdated Show resolved Hide resolved
examples/worlds/lift_drag_nested.sdf Outdated Show resolved Hide resolved
examples/worlds/plane_propeller_demo.sdf Outdated Show resolved Hide resolved
src/ServerPrivate.cc Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch 2 times, most recently from 39a95df to b6015bd Compare July 13, 2022 20:25
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #1589 (88b3c89) into main (a3cbd8c) will decrease coverage by 0.04%.
The diff coverage is 99.27%.

❗ Current head 88b3c89 differs from pull request most recent head c39fbf4. Consider uploading reports for the commit c39fbf4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   63.62%   63.58%   -0.05%     
==========================================
  Files         330      330              
  Lines       25787    25925     +138     
==========================================
+ Hits        16408    16484      +76     
- Misses       9379     9441      +62
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff12f03...c39fbf4. Read the comment docs.

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch 4 times, most recently from cfc50b4 to 27a939c Compare July 14, 2022 01:07
@methylDragon methylDragon mentioned this pull request Jul 15, 2022
Merged
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch 2 times, most recently from d567398 to 7a0000b Compare July 19, 2022 21:45
@methylDragon
Fix python tick-tock symlink
c39fbf4 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 7a0000b to c39fbf4 Compare July 19, 2022 23:51
@methylDragon methylDragon merged commit 17bae14 into main Jul 19, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 19, 2022 23:52
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina