Bumps in Ionic: gz-sim9 #2205
Merged
Bumps in Ionic: gz-sim9 #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
azeey
approved these changes
Oct 11, 2023
83 tasks
This removes the forward declaration and just includes the `gz/rendering/GlobalIlluminationCiVct.hh`. Since CiVctCascadePrivate.hh is not going to be installed, and it's only used by CiVctCascadePrivate.cc, I don't think there's much gain from forward declarations. Signed-off-by: Addisu Z. Taddese <[email protected]>
|
There was a forward declaration that was causing the build to fail. Fixed in 1acf47c |
Signed-off-by: Ian Chen <[email protected]>
…' into iche033/ionic_bumps
|
fix |
Codecov Report
@@ Coverage Diff @@
## main #2205 +/- ##
==========================================
+ Coverage 65.90% 65.92% +0.01%
==========================================
Files 323 323
Lines 30719 30719
==========================================
+ Hits 20245 20251 +6
+ Misses 10474 10468 -6 |
mjcarroll
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gazebo-tooling/release-tools#1027