Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maritime tutorials 💧 - Part 1 of 4 #2257

Merged
merged 21 commits into from
Dec 22, 2023
Merged

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Dec 1, 2023

Summary

This pull request adds a new tutorial section for grouping maritime tutorials. Starting the section, I'm adding four new tutorials under that section.

Screenshot from 2023-12-01 19-17-38

Pinging @crvogt for review.

How to test it

colcon build --merge-install --packages-select gz-sim8 --cmake-target doc

Point your browser to build/gz-sim8/doxygen/html/tutorials.html and go from there.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 1, 2023
@caguero caguero changed the base branch from gz-sim7 to gz-sim8 December 1, 2023 18:20
tutorials/adding_system_plugins.md Outdated Show resolved Hide resolved
tutorials/adding_system_plugins.md Outdated Show resolved Hide resolved
tutorials/adding_system_plugins.md Outdated Show resolved Hide resolved
tutorials/adding_system_plugins.md Outdated Show resolved Hide resolved
tutorials/adding_system_plugins.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/frame_reference.md Outdated Show resolved Hide resolved
tutorials/frame_reference.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
caguero and others added 12 commits December 5, 2023 10:26
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: crvogt <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: crvogt <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
@caguero caguero changed the title Maritime tutorials - Part 1 Maritime tutorials - Part 1 of 4 Dec 5, 2023
Signed-off-by: Carlos Agüero <[email protected]>
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/create_vehicle.md Outdated Show resolved Hide resolved
tutorials/adding_system_plugins.md Show resolved Hide resolved
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
tutorials/adding_visuals.md Outdated Show resolved Hide resolved
caguero and others added 4 commits December 6, 2023 14:15
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
…im/gz-sim into caguero/maritime_tutorials_part1
@caguero caguero changed the title Maritime tutorials - Part 1 of 4 Maritime tutorials 💧 - Part 1 of 4 Dec 7, 2023
Copy link
Contributor

@crvogt crvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes resolved.

@caguero caguero requested a review from ahcorde December 22, 2023 09:33
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment related with Gazebo classic tutorials

tutorials/adding_visuals.md Show resolved Hide resolved
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero merged commit 66ae42c into gz-sim8 Dec 22, 2023
3 of 8 checks passed
@caguero caguero deleted the caguero/maritime_tutorials_part1 branch December 22, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants