Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #2232 to harmonic #2485

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Backport #2232 to harmonic #2485

merged 3 commits into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. Fix warnings generated by NetworkConfigTest (#2469) 

    This test was generating a warning about unused vairables. Unless built
in debug mode, `aserts`are often optimized out we should be using the
`ASSERT` macros from `gtest` instead.

Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129
    arjo129 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    3be099b View commit details
    Browse the repository at this point in the history

  2. Remove systems if their parent entity is removed (#2232) 

    n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.
    @arjo129
    arjo129 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8da3ccd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'gz-sim8' into arjo/backport/2232

    @arjo129
    arjo129 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4fa7117 View commit details
    Browse the repository at this point in the history