-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sky #445
Add support for sky #445
Conversation
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sunny! 🌞
Is there a plan to support Ogre 1 and the sky properties in the near future?
Signed-off-by: Ian Chen <[email protected]>
I think for ogre1, we can just port over the skyx code from gazebo classic. As for supporting other sky properties in ogre2, maybe we can see if it's possible to port the skyx implementation to ogre2. |
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
sdformat 10.1.0 was released with sky DOM so I think we can merge this now. |
@chapulina @iche033 Has anyone looked into this more, including possibly adding some skyx features like storms for ogre2? Having moving clouds back again instead of static skybox would be nice. |
I believe no one has looked into this yet, or has plans to look into it in the near future |
depends on:
Add ogre2 skybox support gz-rendering#168Add Sky DOM sdformat#397Users can now enable a sky in the scene through the
<sky>
SDF element. It's currently only a static skybox background and sky properties like wind speed, humidity, etc are not supported yet. Only works in ogre2 rendering engine.To test:
Known issue:
Sky is not visible to an RGBD camera yet.