Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tape Measure Plugin #456
Tape Measure Plugin #456
Changes from all commits
7d4ab56
32236cc
a062e20
af399c9
3f7f265
8f107d6
041e54b
22d1c0f
f0b022a
0dfec2f
38a6e4e
a0f20f6
cf77ad8
83b0a43
e69d95a
161e979
59d5b33
df26ea2
a7cbc13
a31264c
dda9038
4d41ebe
744e2db
65d122a
acaac9c
d8a7404
762a2d5
aecce0c
2f47f18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this will probably be complicated to achieve with markers, but I'll just make an observation for the future.
The fixed scale means that the points may be too big or too small depending on what's being simulated and the user's zoom level. Maybe they're too big to measure the distance between fingers of a robot hand, but too small when measuring the size of a road. One option would be to scale it according to the zoom level like it's done for the transform controls:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I believe that functionality is coming from this line? After thinking about it for a second, I think the effect comes from the world "moving away" and the visual gizmo staying the same size. @ColeOSRF do you know how this tool is usually handled in large vs small scenarios and when the user is zooming in and out?