-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set collision detector and solver from SDF #684
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo5 #684 +/- ##
===============================================
- Coverage 65.32% 65.26% -0.07%
===============================================
Files 240 240
Lines 17624 17718 +94
===============================================
+ Hits 11513 11563 +50
- Misses 6111 6155 +44
Continue to review full report at Codecov.
|
Removed from beta, this can come in a minor release. |
Signed-off-by: Louise Poubel <[email protected]>
This is ready for review, @scpeters |
@@ -39,6 +39,7 @@ | |||
#include <ignition/physics/RemoveEntities.hh> | |||
#include <ignition/physics/Shape.hh> | |||
#include <ignition/physics/SphereShape.hh> | |||
#include <ignition/physics/World.hh> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for including this header (and other headers) in the header file, if they're really only used in the source file? Does it have something to do with making builds green for macOS and/or Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a little comment on line 26, these were originally here to satisfy the initial entityCast
implementation. There's a chance that this isn't needed anymore since #586, I haven't checked.
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, but otherwise, LGTM assuming that CI checks come back green 🤞
Signed-off-by: Louise Poubel <[email protected]>
🎉 New feature
Requires gazebosim/gz-physics#225
Summary
This makes it possible to choose a different collision detector and solver when using DART. This way, users can choose the combination that suits their simulation best.
Test it
Try setting different options in SDF, for example:
Try the example world:
ign gazebo physics_options.sdf
See that it behaves different from
rolling_shapes.sdf
:rolling_shapes.sdf
physics_options.sdf
I also made the options visible on the GUI:
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸