Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 to 4 20210408 #750

Merged
merged 7 commits into from
Apr 8, 2021
Merged

3 to 4 20210408 #750

merged 7 commits into from
Apr 8, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 8, 2021

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 6 commits March 17, 2021 19:25
Signed-off-by: Louise Poubel <[email protected]>
* Add sensors to scene broadcaster

Signed-off-by: Nate Koenig <[email protected]>

* Update src/systems/scene_broadcaster/SceneBroadcaster.cc

Co-authored-by: Michael Carroll <[email protected]>

* Fix codecheck

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
…ility with Protobuf CMake config (#715)

Signed-off-by: Silvio Traversaro <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from chapulina as a code owner April 8, 2021 15:56
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Apr 8, 2021
Signed-off-by: Nate Koenig <[email protected]>
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #750 (f570749) into ign-gazebo4 (3e8d4e7) will decrease coverage by 0.01%.
The diff coverage is 84.61%.

❗ Current head f570749 differs from pull request most recent head 2f3d544. Consider uploading reports for the commit 2f3d544 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #750      +/-   ##
===============================================
- Coverage        65.48%   65.47%   -0.02%     
===============================================
  Files              237      237              
  Lines            17223    17249      +26     
===============================================
+ Hits             11279    11294      +15     
- Misses            5944     5955      +11     
Impacted Files Coverage Δ
...stems/joint_state_publisher/JointStatePublisher.cc 84.37% <50.00%> (-3.41%) ⬇️
src/systems/scene_broadcaster/SceneBroadcaster.cc 96.87% <95.00%> (-0.12%) ⬇️
src/SimulationRunner.cc 92.95% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8d4e7...2f3d544. Read the comment docs.

@nkoenig nkoenig merged commit 8829840 into ign-gazebo4 Apr 8, 2021
@nkoenig nkoenig deleted the 3-to-4-20210408 branch April 8, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants