Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved marker example to ign-gui #905

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Moved marker example to ign-gui #905

merged 1 commit into from
Jul 12, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 7, 2021

🎉 Enhancement

Summary

As part of the consolitation between scene3D in ign-gui and ign-gazebo, we created a marker plugin in ignition GUI because is not gazebo specific, for this same reason the example should live there too.

This PR gazebosim/gz-gui#247 include the marker example

Checklist

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde requested a review from chapulina July 7, 2021 11:33
@ahcorde ahcorde self-assigned this Jul 7, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 7, 2021
@@ -7,6 +7,8 @@ release will remove the deprecated code.

## Ignition Gazebo 5.x to 6.x

* Marker example has been moved to Ignition GUI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will eventually be more than just the example. We should deprecate the MarkerManager class in this repository too ✨

@ahcorde ahcorde merged commit c07b49c into main Jul 12, 2021
@ahcorde ahcorde deleted the ahcorde/remove/markers branch July 12, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants