Moved marker example to ign-gui #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
mjcarroll
approved these changes
Jul 7, 2021
chapulina
approved these changes
Jul 7, 2021
| @@ -7,6 +7,8 @@ release will remove the deprecated code. | |||
|
|
|||
| ## Ignition Gazebo 5.x to 6.x | |||
|
|
|||
| * Marker example has been moved to Ignition GUI. | |||
There was a problem hiding this comment.
It will eventually be more than just the example. We should deprecate the MarkerManager class in this repository too ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Enhancement
Summary
As part of the consolitation between scene3D in ign-gui and ign-gazebo, we created a marker plugin in ignition GUI because is not gazebo specific, for this same reason the example should live there too.
This PR gazebosim/gz-gui#247 include the
markerexampleChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge