Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ⬅️ 5 #945

Merged
merged 9 commits into from
Aug 4, 2021
Merged

3 ⬅️ 5 #945

merged 9 commits into from
Aug 4, 2021

Conversation

chapulina
Copy link
Contributor

⬅️ Backport

Port ign-gazebo5 to ign-gazebo3

Branch comparison to ign-gazebo4: ign-gazebo4...ign-gazebo5

Cherry-picked some commits that seemed easily backportable

Note to maintainers: Remember to Rebase merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 30, 2021
chapulina added a commit that referenced this pull request Jul 30, 2021
Signed-off-by: Louise Poubel <[email protected]>

Edifice to Citadel (#945)

Signed-off-by: Louise Poubel <[email protected]>
chapulina added a commit that referenced this pull request Jul 30, 2021
Signed-off-by: Louise Poubel <[email protected]>

Edifice to Citadel (#945)

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #945 (723c579) into ign-gazebo3 (8620011) will decrease coverage by 0.00%.
The diff coverage is 64.00%.

❗ Current head 723c579 differs from pull request most recent head 3424980. Consider uploading reports for the commit 3424980 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #945      +/-   ##
===============================================
- Coverage        77.90%   77.90%   -0.01%     
===============================================
  Files              221      221              
  Lines            12639    12678      +39     
===============================================
+ Hits              9847     9877      +30     
- Misses            2792     2801       +9     
Impacted Files Coverage Δ
src/Conversions.cc 81.83% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 8.58% <0.00%> (-0.22%) ⬇️
src/systems/air_pressure/AirPressure.hh 100.00% <ø> (ø)
src/systems/altimeter/Altimeter.hh 100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/contact/Contact.hh 100.00% <ø> (ø)
src/systems/imu/Imu.hh 100.00% <ø> (ø)
src/systems/joint_controller/JointController.hh 100.00% <ø> (ø)
src/systems/logical_camera/LogicalCamera.hh 100.00% <ø> (ø)
src/systems/magnetometer/Magnetometer.hh 100.00% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8620011...3424980. Read the comment docs.

@chapulina chapulina requested a review from caguero August 2, 2021 18:56
herobank110 and others added 9 commits August 4, 2021 08:13
Signed-off-by: Juan Oxoby <[email protected]>

Co-authored-by: Juan Oxoby <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Edifice to Citadel (#945)

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
* add enable/disable diffdrive

Signed-off-by: Guillaume Doisy <[email protected]>

* remove debug

Signed-off-by: Guillaume Doisy <[email protected]>

* do not subscribe to enable if topic is empty

Signed-off-by: Guillaume Doisy <[email protected]>

* add test

Signed-off-by: Guillaume Doisy <[email protected]>

* lint and style

Signed-off-by: Guillaume Doisy <[email protected]>

* change enable type to bool and renamed to enabled

Signed-off-by: Guillaume Doisy <[email protected]>
@chapulina chapulina merged commit a83f56f into ign-gazebo3 Aug 4, 2021
@chapulina chapulina deleted the chapulina/5_to_3 branch August 4, 2021 19:54
chapulina added a commit that referenced this pull request Aug 4, 2021
Signed-off-by: Louise Poubel <[email protected]>

Edifice to Citadel (#945)

Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants