Fix CMake warning and error message types #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fix CMake warning and error message types, so that they're printed to the terminal during the build.
Summary
In a fresh build when I don't have all the dependencies, I'm getting a line that tells me to see BUILD ERRORS above, but there's nothing printed "above."
It's a dependency error, and it's only printed in stdout and not stderr.
So unless I have convenient access to the log directory (which I don't when building from a Dockerfile), I wouldn't know what package was missing without digging.
Upon entering the container and checking,
log/latest/ignition-tools/stderr.log
only has two lines:whereas
stdout.log
has these lines:After the fix, the output looks like:
Checklist
Added testsUpdated documentation (as needed)Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge