Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated use of zmq::poll #261

Closed
jacobperron opened this issue Sep 13, 2021 · 1 comment
Closed

Deprecated use of zmq::poll #261

jacobperron opened this issue Sep 13, 2021 · 1 comment
Assignees
@caguero
Labels
bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏯 fortress Ignition Fortress macOS macOS support

Comments

@jacobperron
Copy link

jacobperron commented Sep 13, 2021 •
edited
Loading

Environment

  • OS Version: macOS
  • Source or binary build?
    Source (branches ign-transport8 and ign-transport10, probably ign-transport9)

Description

  • Expected behavior: No deprecation warnings during build
  • Actual behavior: Deprecation warnings

Steps to reproduce

See https://build.osrfoundation.org/job/ignition_transport-ci-ign-transport10-homebrew-amd64/6/

Also happening on Citadel and probably Dome:

Output

'poll' is deprecated: from 4.8.0, use poll taking std::chrono::duration instead of long

Coming from NodeShared.cc and Discovery.cc
@jacobperron jacobperron added the bug Something isn't working label Sep 13, 2021
@jacobperron jacobperron added macOS macOS support 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Sep 13, 2021
@caguero caguero mentioned this issue Sep 30, 2021
Merged
7 tasks
@Blast545
Copy link
Contributor

Blast545 commented Oct 4, 2021

This was addressed indirectly in main with #265 and directly for Citadel + onward with #268 #269 #270. Closing

@Blast545 Blast545 closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caguero caguero

Labels
bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏯 fortress Ignition Fortress macOS macOS support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacobperron @caguero @Blast545