Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Homebrew warning (backport from Fortress) #268

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 30, 2021

Signed-off-by: Carlos Agüero [email protected]

🦟 Bug fix

See issue #261.

Summary

This is a backport from this commit: 51df6a8

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #268 (64abc53) into ign-transport8 (5d88091) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport8     #268      +/-   ##
==================================================
+ Coverage           83.76%   83.79%   +0.02%     
==================================================
  Files                  51       51              
  Lines                5033     5036       +3     
==================================================
+ Hits                 4216     4220       +4     
+ Misses                817      816       -1     
Impacted Files Coverage Δ
src/NodeSharedPrivate.hh 100.00% <ø> (ø)
src/Discovery.cc 77.77% <100.00%> (+2.77%) ⬆️
src/NodeShared.cc 78.95% <100.00%> (+0.05%) ⬆️
include/ignition/transport/Discovery.hh 87.94% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d88091...64abc53. Read the comment docs.

@chapulina chapulina merged commit 4371fac into ign-transport8 Sep 30, 2021
@chapulina chapulina deleted the poll_ms_8 branch September 30, 2021 22:18
@chapulina chapulina added the macOS macOS support label Sep 30, 2021
caguero pushed a commit that referenced this pull request Oct 4, 2021
Port forward fix Homebrew warning

Signed-off-by: Carlos Agüero <[email protected]>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11 macOS macOS support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants