Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static on registrationCb and unregistrationCb. #273

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

mahiuchun
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 18, 2021
@mahiuchun mahiuchun changed the base branch from ign-transport10 to ign-transport8 October 18, 2021 18:31
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #273 (0cd7395) into ign-transport8 (d2b2ccd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport8     #273   +/-   ##
===============================================
  Coverage           83.77%   83.77%           
===============================================
  Files                  51       51           
  Lines                5036     5036           
===============================================
  Hits                 4219     4219           
  Misses                817      817           
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b2ccd...0cd7395. Read the comment docs.

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the patch!

It seems that the reason for this was to avoid ABI breakage at some point.

@chapulina chapulina merged commit ecc2da4 into gazebosim:ign-transport8 Nov 4, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants