Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the default value of IGN_PARTITION #281

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Dec 13, 2021

Signed-off-by: Martin Pecka [email protected]

🎉 New feature

Closes: many searches of the docs to figure out whether it is <HOSTNAME>:<USERNAME> or <USERNAME>:<HOSTNAME> :)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Dec 13, 2021
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, @peci1 !

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #281 (a91f413) into ign-transport8 (ecc2da4) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-transport8     #281      +/-   ##
==================================================
+ Coverage           83.77%   83.79%   +0.01%     
==================================================
  Files                  51       51              
  Lines                5036     5036              
==================================================
+ Hits                 4219     4220       +1     
+ Misses                817      816       -1     
Impacted Files Coverage Δ
include/ignition/transport/Discovery.hh 87.94% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc2da4...a91f413. Read the comment docs.

@chapulina chapulina added the documentation Improvements or additions to documentation label Dec 13, 2021
@chapulina chapulina merged commit f771ab1 into gazebosim:ign-transport8 Dec 13, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants