Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 ➡️ 10 #299

Merged
merged 2 commits into from
Mar 15, 2022
Merged

8 ➡️ 10 #299

merged 2 commits into from
Mar 15, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-transport8 to ign-transport10

Branch comparison: ign-transport10...ign-transport8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@chapulina chapulina requested a review from caguero as a code owner March 15, 2022 17:27
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #299 (6a5a866) into ign-transport10 (caf412d) will decrease coverage by 0.05%.
The diff coverage is 76.47%.

@@                 Coverage Diff                 @@
##           ign-transport10     #299      +/-   ##
===================================================
- Coverage            89.14%   89.09%   -0.06%     
===================================================
  Files                   51       51              
  Lines                 4763     4777      +14     
===================================================
+ Hits                  4246     4256      +10     
- Misses                 517      521       +4     
Impacted Files Coverage Δ
include/ignition/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/ignition/transport/Publisher.hh 100.00% <ø> (ø)
include/ignition/transport/RepHandler.hh 85.36% <ø> (ø)
log/include/ignition/transport/log/QueryOptions.hh 100.00% <ø> (ø)
src/cmd/ign.cc 95.31% <75.00%> (-2.13%) ⬇️
src/cmd/topic_main.cc 95.00% <75.00%> (-1.50%) ⬇️
include/ignition/transport/ReqHandler.hh 80.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f60438...6a5a866. Read the comment docs.

@chapulina chapulina merged commit 4daffb6 into ign-transport10 Mar 15, 2022
@chapulina chapulina deleted the chapulina/8_to_10 branch March 15, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants