Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exec instead of popen to run CLI11 based binaries #300

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 18, 2022

🦟 Bug fix

Summary

See gazebosim/gz-launch#151

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner March 18, 2022 16:06
@azeey azeey self-assigned this Mar 18, 2022
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #300 (7ac5409) into ign-transport10 (4daffb6) will not change coverage.
The diff coverage is n/a.

❗ Current head 7ac5409 differs from pull request most recent head 32ea3ce. Consider uploading reports for the commit 32ea3ce to get more accurate results

@@               Coverage Diff                @@
##           ign-transport10     #300   +/-   ##
================================================
  Coverage            89.09%   89.09%           
================================================
  Files                   51       51           
  Lines                 4777     4777           
================================================
  Hits                  4256     4256           
  Misses                 521      521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4daffb6...32ea3ce. Read the comment docs.

@azeey azeey merged commit 59028a4 into gazebosim:ign-transport10 Mar 23, 2022
@azeey azeey deleted the use_exec branch March 23, 2022 15:51
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants