Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HIDE_SYMBOLS_BY_DEFAULT #461

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of testing gazebosim/gz-cmake#392.

Summary

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of testing gazebosim/gz-cmake#392.

Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #461 (6e864e9) into main (c0cdbef) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 6e864e9 differs from pull request most recent head dd94bb8. Consider uploading reports for the commit dd94bb8 to get more accurate results

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   87.80%   87.76%   -0.04%     
==========================================
  Files          59       59              
  Lines        5699     5699              
==========================================
- Hits         5004     5002       -2     
- Misses        695      697       +2     

see 2 files with indirect coverage changes

@scpeters scpeters merged commit c6d47cc into main Nov 13, 2023
10 of 11 checks passed
@scpeters scpeters deleted the scpeters/hide_symbols_by_default branch November 13, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants