-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor CLI11 library inside ignition-utils #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me assuming that we're convinced that we want to vendor this library. My only suggestion would be to create a basic example to show how to use it in a very basic way.
From @scpeters homebrew has a package: https://github.com/Homebrew/homebrew-core/blob/master/Formula/cli11.rb |
looks like it's in vcpkg as well: https://repology.org/project/cli11/versions |
3d745d3
to
a108e5d
Compare
Signed-off-by: Michael Carroll <[email protected]>
@scpeters and I discussed this with @j-rivero offline. Since this will only be used in executables, is header only, and has no existing Debian package, it makes sense to include the Additionally, rather than using the packaged versions for This is still pending me developing a prototype for using this with |
Closing and reopening to see if DCO takes effect |
How do we deal with side-by-side installs in the future? We have used inline namespaces for this in our other packages, but CLI will have its own namespace. This could potentially be a problem down the road if we want to update the version of CLI we vendor. |
are you concerned about conflicting header file locations or conflicting symbols? I would expect CLI11 to only be used in executables, so I wouldn't expect problems with symbols |
Yeah, I think you're right. If we limit its usage only to executables, we shouldn't have a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be working well enough with gazebosim/gz-transport#216
let's go ahead and merge and make a prerelease
We could also use a nightly |
we don't have to wait a day if we make a prerelease now |
Depends on: gazebosim/gz-cmake#143
Signed-off-by: Michael Carroll [email protected]