Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in garden : ign-rendering7 #608

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Bumps in garden : ign-rendering7 #608

merged 2 commits into from
Apr 14, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 13, 2022
chapulina
chapulina approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments, LGTM once CI is 🟢

src/Utils_TEST.cc Outdated Show resolved Hide resolved
test/integration/depth_camera.cc Outdated Show resolved Hide resolved
test/integration/render_pass.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #608 (959bcc2) into main (7b4b3ee) will increase coverage by 26.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #608       +/-   ##
===========================================
+ Coverage   53.60%   80.00%   +26.39%     
===========================================
  Files         214        1      -213     
  Lines       21355       15    -21340     
===========================================
- Hits        11448       12    -11436     
+ Misses       9907        3     -9904
Impacted Files Coverage Δ
ogre2/src/Ogre2Visual.cc
ogre2/src/Ogre2RenderTarget.cc
.../ignition/rendering/base/BaseSegmentationCamera.hh
ogre2/src/Ogre2ParticleNoiseListener.hh
ogre/src/OgreVisual.cc
ogre2/src/Ogre2ArrowVisual.cc
ogre2/src/Ogre2InertiaVisual.cc
...nclude/ignition/rendering/base/BaseRenderEngine.hh
src/base/BaseRenderEngine.cc
ogre/src/OgreJointVisual.cc
... and 205 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4b3ee...959bcc2. Read the comment docs.

@methylDragon
Revert comment bumps
959bcc2 
Signed-off-by: methylDragon <[email protected]>
@chapulina
Copy link
Contributor

All 🟢 !

@chapulina chapulina merged commit b161e62 into main Apr 14, 2022
@chapulina chapulina deleted the ci_matching_branch/bump_garden_ign-rendering7 branch April 14, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina