Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build in case no suitable OGRE is found #726

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Sep 18, 2022

🦟 Bug fix

Summary

Trying to build Garden on Windows via conda results in a state where ogre is not found (conda provides 1.13, but gz-rendering wants 1.9). Due to the badly written if(), if ogre is not found, the whole build fails with:

--- stderr: gz-rendering7
CMake Warning at D:/programovani/ign5-ws/install/share/cmake/gz-cmake3/cmake3/FindGzOGRE.cmake:173 (find_package):
  Could not find a configuration file for package "OGRE" that is compatible
  with requested version "1.9".

  The following configuration files were considered but not accepted:

    D:/Programy/Conda/envs/ign5-ws/Library/CMake/OGREConfig.cmake, version: 13.4.4

Call Stack (most recent call first):
  D:/programovani/ign5-ws/install/share/cmake/gz-cmake3/cmake3/GzUtils.cmake:231 (find_package)
  CMakeLists.txt:78 (gz_find_package)


CMake Error at CMakeLists.txt:87 (if):
  if given arguments:

    "VERSION_GREATER_EQUAL" "1.10.0"

  Unknown arguments specified


---
Failed   <<< gz-rendering7 [4.59s, exited with code 1]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@peci1 peci1 requested a review from iche033 as a code owner September 18, 2022 01:09
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 18, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #726 (4f167f3) into gz-rendering7 (7e3371b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           gz-rendering7     #726   +/-   ##
==============================================
  Coverage          74.14%   74.14%           
==============================================
  Files                164      164           
  Lines              14351    14351           
==============================================
  Hits               10641    10641           
  Misses              3710     3710           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 318fd83 into gazebosim:gz-rendering7 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants