Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch file may start wrong ign-gazebo version #133

Closed
chapulina opened this issue Jan 26, 2021 · 3 comments
Closed

Launch file may start wrong ign-gazebo version #133

chapulina opened this issue Jan 26, 2021 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed OOBE 📦✨ Out-of-box experience ROS 1 ROS 1 ROS 2 ROS 2

Comments

@chapulina
Copy link
Contributor

ign_gazebo.launch starts Ignition Gazebo with the ign gazebo command line command:

https://github.com/ignitionrobotics/ros_ign/blob/a4bc25fde117f9ce7279c83dc419bfb0eb3983b9/ros_ign_gazebo/launch/ign_gazebo.launch.py#L34

https://github.com/ignitionrobotics/ros_ign/blob/968c31586bbe9964a3788d5970a90f88dfc3cb25/ros_ign_gazebo/scripts/ign_gazebo#L16

The problem is that, if a user has more than one ign-gazebo version installed, that will launch the latest version, which may not necessarily be what the ROS user wants. For example, if I have ros-foxy-ros-ign (which uses Citadel, i.e. ign-gazebo3) and Ignition Dome (i.e. ign-gazebo4) installed, the launch file will start a version of Ignition that may not be compatible with the rest of the things being launched.

The command line tool accepts the --force-version argument to specify what version to launch. But that is quite strict at the moment, and requires passing the fully qualified version, including minor and patch numbers (see gazebosim/gz-tools#36). This makes it complicated to hardcode the version on the launch file.

@chapulina chapulina added bug Something isn't working ROS 2 ROS 2 ROS 1 ROS 1 labels Jan 26, 2021
@chapulina chapulina added the help wanted Extra attention is needed label Jan 28, 2021
@caioaamaral
Copy link

@chapulina I'm addressing --force-version here at gazebosim/gz-tools#44 and currently writing a bugfix for this one.

@chapulina
Copy link
Contributor Author

Thanks, @caioaamaral !

@ahcorde
Copy link
Collaborator

ahcorde commented Mar 25, 2022

Added a new launch argument #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed OOBE 📦✨ Out-of-box experience ROS 1 ROS 1 ROS 2 ROS 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants