[ros2] Add default ign_gazebo version

[caioaamaral]

🦟 Bug fix

Fixes #133

Summary

This change uses as the default version the dependency resolved by the package manifest (which uses ignition-gazebo3 for the foxy distro). This is accomplished by appending the flag --force-version (only when it's not already set) to the ign_args

Checklist

• Signed all commits for DCO

• Added tests

• Updated documentation (as needed)

• Updated migration guide (as needed)

• codecheck passed (See contributing)

• All tests passed (See test coverage)

• While waiting for a review on your PR, please help review another open pull request to support the maintainers

• Depends on: Relax version verification gz-tools#44 (to allow passing the major version only)

Note to maintainers: Remember to use Squash-Merge

[caioaamaral]

I added to the checklist another pr which this one depends on (gazebosim/gz-tools#44)

Is a unit test desired? (maybe we could test it by using specific configurations with the ci?)

[caioaamaral]

@chapulina I've opened the PR to the wrong branch, could you please move it to the ros2 branch please? 🤦

edit: fixed

[caioaamaral]

To the reviewer:

At least locally I couldn't find the package when my workspace was build with --merge-install flag, apparently the overlay does not work with such configuration (also noticed that the package manifest was not installed).

[ahcorde]

do you mind to fix the conflicts with the main branch ?

[caioaamaral]

do you mind to fix the conflicts with the main branch ?

Done

[caioaamaral]

Friendly ping.

I think this one is good to go now that gazebosim/gz-tools#44 is merged

[chapulina]

Thanks, @caioaamaral , we'll take a look soon. Note that we'll need an ign-tools release, and also upload the released version to packages.ros.org, before this can be merged.

[chapulina]

I'm getting an error on launch, I tried compiling with --merge-install and without. Do you know what's happening?

  File "/home/chapulina/dev_focal/ws_foxy/install/ros_ign_gazebo/share/ros_ign_gazebo/launch/ign_gazebo.launch.py", line 39, in generate_lau
nch_description
    OpaqueFunction(__get_ign_args)
TypeError: __init__() takes 1 positional argument but 2 were given

[chapulina]

@caioaamaral , are you still working on this PR?

[caioaamaral]

@caioaamaral , are you still working on this PR?

Sorry for the delay. I'll have a look by the end of this week

[chapulina]

Hi @caioaamaral , I'm closing this due to inactivity, but feel free to reopen if you start working on it again. Thanks!