Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate IGNITION- CMake variables #1057

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Migrate IGNITION- CMake variables #1057

merged 2 commits into from
Jun 27, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon enabled auto-merge (squash) June 26, 2022 00:37
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 26, 2022
@methylDragon methylDragon mentioned this pull request Jun 26, 2022
Closed
17 tasks
@codecov
Copy link

codecov bot commented Jun 26, 2022 •
edited
Loading

Codecov Report

Merging #1057 (3bc5d15) into main (08ce894) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         149      149           
  Lines       18445    18445           
=======================================
  Hits        15388    15388           
  Misses       3057     3057

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ce894...3bc5d15. Read the comment docs.

chapulina
chapulina reviewed Jun 26, 2022
View reviewed changes
src/gz_TEST.cc
{
return std::string(GZ_PATH) + "/ign";
return std::string(GZ_PATH);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures seem to indicate we should have /gz here, but that would be different from the other libs. Gotta look more carefully to see what's going on

Copy link
Contributor Author

@methylDragon methylDragon Jun 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a get_filename_component(GZ_PATH ${GZ_PROGRAM} DIRECTORY) which stripped the filename :>

I just used GZ_PROGRAM instead to just directly use the program path, which puts it in line with the other libs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 26, 2022
@methylDragon
Update tests
3bc5d15 
Signed-off-by: methylDragon <[email protected]>
chapulina
chapulina approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@methylDragon methylDragon merged commit e372371 into main Jun 27, 2022
@methylDragon methylDragon deleted the gz_cmake_project branch June 27, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina