Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : sdformat #1078

Merged
merged 2 commits into from
Jul 15, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : sdformat #1078

merged 2 commits into from
Jul 15, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from efbe0b2 to b9417ab Compare July 12, 2022 23:57
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon
Move pybind files (#1078)
46e20af 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Partial source and cmake migrations (#1078)
6b5b817 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from b9417ab to 6b5b817 Compare July 13, 2022 19:38
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #1078 (f0a5b0a) into main (033b9bb) will not change coverage.
The diff coverage is n/a.

❗ Current head f0a5b0a differs from pull request most recent head 6ecd48f. Consider uploading reports for the commit 6ecd48f to get more accurate results

@@           Coverage Diff           @@
##             main    #1078   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         154      154           
  Lines       18702    18702           
=======================================
  Hits        15546    15546           
  Misses       3156     3156
Impacted Files Coverage Δ
python/src/sdf/_gz_sdformat_pybind11.cc 100.00% <ø> (ø)
src/FrameSemantics.cc 84.43% <ø> (ø)
src/Utils.hh 94.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033b9bb...6ecd48f. Read the comment docs.

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 6b5b817 to 6ecd48f Compare July 13, 2022 21:46
@jennuine jennuine mentioned this pull request Jul 14, 2022
Merged
9 tasks
@methylDragon methylDragon merged commit 813f06e into main Jul 15, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 15, 2022 00:35
methylDragon added a commit that referenced this pull request Jul 15, 2022
@methylDragon
Move pybind files (#1078)
0553922 
Signed-off-by: methylDragon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina