-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing relative paths in URDF #1213
Conversation
aa23a6b
to
35e81ca
Compare
Codecov Report
@@ Coverage Diff @@
## sdf9 #1213 +/- ##
=======================================
Coverage 88.35% 88.35%
=======================================
Files 63 63
Lines 10093 10093
=======================================
Hits 8918 8918
Misses 1175 1175
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks for the contribution. Since this is a small change, would you mind setting the target branch to |
When parsing a URDF file, the `_source` parameter is set to "urdf file" which breaks relative path resolution downstream. This commit changes the call to `sdf::readDoc` to use `filename` as the `_source` parameter instead. Signed-off-by: Robert Plante <[email protected]>
35e81ca
to
6462a62
Compare
No problem. Rebased onto |
🦟 Bug fix
Summary
When parsing a URDF file, the
_source
parameter is set to "urdf file" which breaks relative path resolution later on. This commit changes the call tosdf::readDoc
to usefilename
as the_source
parameter instead.Additional Information
I came across this issue while testing out a physics plugin I am developing for PhysX 4.1 integration. Searching all repos pulled by colcon reveals no other uses of the phrase "urdf file" as a special case. Testing has revealed no new issues.