Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in Ionic: sdformat15 #1338

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Bumps in Ionic: sdformat15 #1338

merged 2 commits into from
Oct 11, 2023

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Oct 10, 2023

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from scpeters as a code owner October 10, 2023 20:55
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1338 (5612972) into main (297e5a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 5612972 differs from pull request most recent head 5bff370. Consider uploading reports for the commit 5bff370 to get more accurate results

@@           Coverage Diff           @@
##             main    #1338   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         134      134           
  Lines       17669    17669           
=======================================
  Hits        16328    16328           
  Misses       1341     1341           

@iche033
Copy link
Contributor

iche033 commented Oct 10, 2023

I think the homebrew build needs a sdformat15.rb formula?

@scpeters
Copy link
Member

I think the homebrew build needs a sdformat15.rb formula?

there wasn't an sdformat15 Alias, so maybe the script failed

@azeey azeey changed the title Bumps in Ionic: sdformat14 Bumps in Ionic: sdformat15 Oct 11, 2023
@azeey
Copy link
Collaborator Author

azeey commented Oct 11, 2023

osrf/homebrew-simulation#2465

I guess the bump_dependency.bash script wants all main branches bumped first, which includes creating aliases in Homebrew. I thought we could just run the script, which would hopefully create the formula and do the bumps in the same go. Since that doesn't seem to be working well, I suggest we merge all the bump PRs first. I'll create the aliases for Homebrew.

@azeey
Copy link
Collaborator Author

azeey commented Oct 11, 2023

I was wondering why the macOS Github Action passed. There's a hardcoded sdformat14 in workflow file, so it was using that formula.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 5851546 into main Oct 11, 2023
12 checks passed
@azeey azeey deleted the azeey/ionic_bumps branch October 11, 2023 23:47
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Apr 2, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merging sdf dom element changes with main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants