Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdf -> usd: Added Visual and geometries #829

Merged
merged 21 commits into from
Feb 24, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 26, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

This PR adds support for Visuals and Geometries

  • Support for visuals and geometries
  • Visual and Geometry tests
  • Some minor improvements in doc and tests

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Jan 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2022

Codecov Report

Merging #829 (0d483a7) into sdf12 (5a2b5df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #829   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          78       78           
  Lines       12635    12635           
=======================================
  Hits        11483    11483           
  Misses       1152     1152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2b5df...0d483a7. Read the comment docs.

@adlarkin adlarkin mentioned this pull request Jan 26, 2022
8 tasks
ahcorde and others added 2 commits January 26, 2022 23:10
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
@koonpeng
Copy link

koonpeng commented Jan 27, 2022

I tried to convert the ur10 model, but it cannot find the mesh files

[Err] [SystemPaths.cc:377] Unable to find file with URI [model://ur10/meshes/base.dae]
[Err] [SystemPaths.cc:467] Could not resolve file [model://ur10/meshes/base.dae]
[Err] [MeshManager.cc:119] Invalid mesh filename extension[]

The sdf works in ign gazebo, so I'm guessing the search directory is different somehow.


Managed to make it work by setting IGN_FILE_PATH instead of IGN_GAZEBO_RESOURCE_PATH. But I can't find any problems with the transformations

image

@adlarkin
Copy link
Contributor

I tried to convert the ur10 model, but it cannot find the mesh files

Do you need to use this PR for material support? #831

@koonpeng
Copy link

Do you need to use this PR for material support? #831

I did not use the PR, but I don't think it is needed. I heard from @ahcorde that the transformations for ur10 downloaded from ignition fuel is wrong so I am trying to reproduce it.

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few updates in 379defd. Overall, LGTM once the questions I have below are addressed.

usd/src/sdf_parser/sdf2usd_TEST.cc Show resolved Hide resolved
usd/src/sdf_parser/Geometry.cc Show resolved Hide resolved
usd/src/sdf_parser/Geometry.cc Show resolved Hide resolved
Base automatically changed from ahcorde/sdf_to_usd_links to sdf12 February 18, 2022 16:34
@ahcorde
Copy link
Collaborator Author

ahcorde commented Feb 18, 2022

@scpeters or @azeey do you mind to review it ?

@scpeters scpeters added the usd label Feb 21, 2022
@ahcorde ahcorde enabled auto-merge (squash) February 24, 2022 08:36
@ahcorde ahcorde merged commit ad61117 into sdf12 Feb 24, 2022
@ahcorde ahcorde deleted the ahcorde/sdf_to_usd_visuals branch February 24, 2022 09:42
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants