Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD to SDF: Apply rigid body to Model not to Link #889

Merged
merged 7 commits into from
Mar 23, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Mar 21, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Summary

Applied rigid body to Model not to Link. Without this fix the link will update the position and not the model generating wrong behaviour in Issac Sim Physics

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added the usd label Mar 21, 2022
@ahcorde ahcorde requested a review from adlarkin March 21, 2022 12:05
@ahcorde ahcorde requested a review from azeey as a code owner March 21, 2022 12:05
@ahcorde ahcorde self-assigned this Mar 21, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner March 21, 2022 12:05
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 21, 2022
Signed-off-by: ahcorde <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #889 (158cd83) into sdf12 (9999f55) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf12     #889      +/-   ##
==========================================
- Coverage   88.16%   88.15%   -0.01%     
==========================================
  Files         100      100              
  Lines       14637    14636       -1     
==========================================
- Hits        12904    12903       -1     
  Misses       1733     1733              
Impacted Files Coverage Δ
usd/src/UsdTestUtils.hh 99.00% <ø> (-0.01%) ⬇️
usd/src/sdf_parser/Link.cc 61.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9999f55...158cd83. Read the comment docs.

@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 22, 2022

@osrf-jenkins retest this please

usd/src/sdf_parser/Link.cc Outdated Show resolved Hide resolved
usd/src/sdf_parser/Link_Sdf2Usd_TEST.cc Outdated Show resolved Hide resolved
usd/src/sdf_parser/Link_Sdf2Usd_TEST.cc Outdated Show resolved Hide resolved
@ahcorde ahcorde requested a review from adlarkin March 23, 2022 11:56
@ahcorde ahcorde merged commit 425985f into sdf12 Mar 23, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf/fix_rigid_body branch March 23, 2022 14:58
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants