-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USD to SDF: Fixed header guard #906
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #906 +/- ##
=======================================
Coverage 88.11% 88.11%
=======================================
Files 100 100
Lines 14651 14651
=======================================
Hits 12909 12909
Misses 1742 1742 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
…gnitionrobotics/sdformat into ahcorde/usd_to_sdf/headerGuard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small comment.
Signed-off-by: ahcorde <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: ahcorde [email protected]
🦟 Bug fix
Summary
USD to SDF: Fixed header guard
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.