Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verkle trie: Update codesize key in account update #48

Closed
wants to merge 2 commits into from
Closed

verkle trie: Update codesize key in account update #48

wants to merge 2 commits into from

Conversation

jwasinger
Copy link
Collaborator

@jwasinger jwasinger commented Dec 27, 2021 •
edited
Loading

with this, TryUpdateAccount will touch the codeSize bucket giving it size 0.

@jwasinger
Copy link
Collaborator Author

jwasinger commented Dec 27, 2021 •
edited
Loading

@gballet the problem with this is that we don't have convenient access to the account's code size here. I'm unsure of a clean way to do it.

@jwasinger jwasinger changed the title verkle trie: touch code size bucket in account update verkle trie: Update codesize key in account update Dec 27, 2021
@jwasinger
Copy link
Collaborator Author

Nevermind. The CodeSize key is already updated in core/state/database.go. I was encountering an edge-case in #44 where the CodeSize key isn't updated in the trie when the account is an EOA. Pushed the fix to that PR.

@jwasinger jwasinger closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman Awaiting requested review from holiman holiman will be requested when the pull request is marked ready for review holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwasinger