Witness charging order with limits #502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
witness-charging-order-with-limits
branch
2 times, most recently
from
caa00f3
to
f7db43f
Compare
gballet
changed the base branch from
kaustinen-with-shapella
to
jsign-witness-fix
gballet
force-pushed
the
witness-charging-order-with-limits
branch
from
f96a41c
to
e220c74
Compare
Signed-off-by: Guillaume Ballet <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
gballet
force-pushed
the
witness-charging-order-with-limits
branch
from
e220c74
to
f2b8d24
Compare
* ci: new workflows for testing Signed-off-by: Ignacio Hagopian <[email protected]> * nit Signed-off-by: Ignacio Hagopian <[email protected]> * ci: fix stable consumption Signed-off-by: Ignacio Hagopian <[email protected]> * fix Signed-off-by: Ignacio Hagopian <[email protected]> * more fixes Signed-off-by: Ignacio Hagopian <[email protected]> * more fixes Signed-off-by: Ignacio Hagopian <[email protected]> * update tag Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Guillaume Ballet <[email protected]>
jsign
force-pushed
the
jsign-witness-fix
branch
from
b4b1ff0
to
9635cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #495, which doesn't pass the gas usage function as a parameter, but the total amount of gas available. This approach has two advantages:
UseGasfunction signature inmasterfor the live tracer, which will make it trickier to handleThe difficulty was distinguishing the gas that is to be charged (consumed), from the gas that is requested (wanted). If
wanted > chargedthen it is known that the contract ran out of gas.In order to do so
touch*functions are changed to return theconsumedandwantedgas. Locations will only be added to the witness ifconsumed == wanted.Touchfunctions change to only return thewantedgas, so that thegas*functions can return it (in order to let the interpreter loop know that the dynamic gas is too much, while only adding locations that were fully paid for to the witness.consumed < wantedcomparison to figure out if the subcall ran out of gas.