Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in Eth2 JSON-RPC #8

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Minor fixes in Eth2 JSON-RPC #8

merged 5 commits into from
Jan 13, 2021

Conversation

mkalinin
Copy link

Changeset

  • Functional fixes

    • block number is computed as parent.number + 1 allowing for empty slots; temporal workaround (though, maybe not)
    • include parent_hash into ExecutableData making the change less intrusive for beacon node codebase; thus, parent_hash is removed from eth2_insertBlock params
    • make eth2_insertBlock return true/false explicitly

  • Aesthetic fixes

    • ParentRoot renamed to ParentHash

gballet
gballet approved these changes Jan 13, 2021
View reviewed changes
Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to rebase it on the latest geth before merging, but this is getting too involved, I'll do that after the merge.

@gballet gballet merged commit 3ded09c into gballet:catalyst-for-executable-beacon-chain Jan 13, 2021
gballet added a commit that referenced this pull request Feb 12, 2021
@mkalinin @gballet
Minor fixes in Eth2 JSON-RPC (#8)
c04f25a 
* Minor fixes in Eth2 JSON-RPC

* fix linter issues

* fix unit tests

* add a couple comments

* move eth2 code to its own file to simplify rebase

Co-authored-by: Guillaume Ballet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkalinin @gballet