Allow LOAD FRAGMENT
#1552
Merged
Allow LOAD FRAGMENT
#1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
enhancement
Rangi42
force-pushed
the
load-fragment
branch
3 times, most recently
from
941ff16
to
3eaf9d4
Compare
|
I think this just needs more test cases to cover whatever issues people are expecting could occur. |
Rangi42
force-pushed
the
load-fragment
branch
from
3eaf9d4
to
4ad0fa3
Compare
$ xxd test/link/load-fragment/section-fragment/ref.out.bin
00000000: 18fe 1800 4865 6c6c 6f20 776f 726c 6421 ....Hello world!
00000010: 18ee 18fc .... |
This was implemented in gbdev#736 but removed after discussion in gbdev#869. Fixes gbdev#1537
Rangi42
force-pushed
the
load-fragment
branch
from
4ad0fa3
to
bdce5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was implemented in #736 but removed after discussion in #869.
Fixes #1537