Don't fail when a value can't be converted to a primitive

gcanti · Mar 11, 2024 · 6e9f926 · 6e9f926
1 parent 50e8e63
commit 6e9f926
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Either.ts b/src/Either.ts
@@ -1456,7 +1456,11 @@ export const toUnion: <E, A>(fa: Either<E, A>) => E | A = /*#__PURE__*/ foldW(id
  * @since 2.0.0
  */
 export function toError(e: unknown): Error {
-  return e instanceof Error ? e : new Error(String(e))
+  try {
+    return e instanceof Error ? e : new Error(String(e))
+  } catch (error) {
+    return new Error()
+  }
 }
 
 /**

diff --git a/test/Either.ts b/test/Either.ts
@@ -393,6 +393,20 @@ describe.concurrent('Either', () => {
       }, _.toError),
       _.left(new Error('string error'))
     )
+
+    U.deepStrictEqual(
+      _.tryCatch(() => {
+        throw Object.create(null)
+      }, _.toError),
+      _.left(new Error())
+    )
+
+    U.deepStrictEqual(
+      _.tryCatch(() => {
+        throw { toString: [] }
+      }, _.toError),
+      _.left(new Error())
+    )
   })
 
   describe.concurrent('getEq', () => {