Deprecated inspect() replaced with symbol keyed function. #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcanti
force-pushed
the
master
branch
2 times, most recently
from
93de5eb
to
6f0676d
Compare
|
Superseded by #892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One possible solution to #408 is to replace the inspect member functions with functions keyed on the appropriate symbol (as this pull request does). It also uses the
Symbol.forapproach, as this shouldn't error if the symbol doesn't exist, simply create a new symbol in the global symbol registry (in a browser, this would probably be the case).I'm not personally sure of the status of support for custom inspection across browsers (or the mechanism). I can't see any sign of support, in which case this might well be effectively "no change" for browsers, but a fix for Node as the runtime.