Implementation of user agent. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| properties.load(inputStream); | ||
| } | ||
| catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Instead of throwing, it would be a nicer experience to just fall back to a default string. This code gets hit for every request. If for some reason we cannot read the properties, then no requests would work. Just returning a default string, like "unknown" would make the failure to read not have big impact.
There was a problem hiding this comment.
this sounds like a good idea, instead of returning an unknown, it might be more informative just to return an empty String as Version Number.
gcheng
pushed a commit
that referenced
this pull request
Mar 9, 2013
Clean up service bus assets created as part of test at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.