Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 #273

Merged
merged 16 commits into from
Apr 17, 2022
Merged

500 #273

merged 16 commits into from
Apr 17, 2022

Conversation

joamatab
Copy link
Contributor

  • refactor cross_section. I recommend reviewing the Layout Tutorial -> Paths and CrossSections
    • include routing parameters (width, layer)
    • rename ports to port_names
    • make it immutable and remove add method
    • raise Error when creating a foreign key
    • rename ports to port_names
  • refactor Section
    • make it immutable
    • raise Error when creating a foreign key
  • add gf.Pdk
    • add gf.get_component(component_spec) returns a Component from the active PDK using the registered Cells
    • add gf.get_cross_section(cross_section_spec) returns a CrossSection from the active PDK using the registered CrossSectionFactory
    • add Pdk.register_cells()
    • add Pdk.register_cross_sections()
  • add gf.ACTIVE_PDK
  • delete klayout autoplacer code. Use gf.read.from_yaml instead.
  • delete YAML placer code. Use gf.read.from_yaml instead.

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #273 (33427f2) into master (6422d3c) will increase coverage by 2.26%.
The diff coverage is 83.66%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   80.49%   82.75%   +2.26%     
==========================================
  Files         409      381      -28     
  Lines       17304    15322    -1982     
==========================================
- Hits        13928    12679    -1249     
+ Misses       3376     2643     -733     
Impacted Files Coverage Δ
gdsfactory/add_grating_couplers.py 54.34% <0.00%> (-37.69%) ⬇️
gdsfactory/cell.py 79.21% <ø> (ø)
gdsfactory/components/ring_single_heater.py 100.00% <ø> (ø)
gdsfactory/components/straight_pin.py 100.00% <ø> (ø)
gdsfactory/export/to_np.py 26.08% <ø> (ø)
gdsfactory/get_netlist.py 73.91% <ø> (ø)
gdsfactory/gf.py 64.61% <0.00%> (-0.16%) ⬇️
gdsfactory/name.py 45.00% <ø> (-30.00%) ⬇️
gdsfactory/read/from_picwriter.py 88.37% <0.00%> (ø)
gdsfactory/routing/add_fiber_array.py 76.47% <ø> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6422d3c...33427f2. Read the comment docs.

@joamatab joamatab merged commit b74e29e into master Apr 17, 2022
@joamatab joamatab deleted the 500 branch April 17, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant