51016b

[joamatab]

rename triangle to triangles, to avoid conflict names with triangle module

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.62%.

Quality metrics	Before	After	Change
Complexity	5.65 ⭐	5.60 ⭐	-0.05 👍
Method Length	151.69 😞	152.08 😞	0.39 👎
Working memory	23.16 ⛔	22.92 ⛔	-0.24 👍
Quality	42.45% 😞	43.07% 😞	0.62% 👍

Other metrics	Before	After	Change
Lines	963	966	3

Changed files	Quality Before	Quality After	Quality Change
gdsfactory/components/init.py	31.00% 😞	31.00% 😞	0.00%
gdsfactory/components/dicing_lane.py	76.69% ⭐	76.69% ⭐	0.00%
gdsfactory/components/grating_coupler_elliptical_arbitrary.py	36.05% 😞	36.23% 😞	0.18% 👍
gdsfactory/components/straight_heater_meander.py	31.88% 😞	34.03% 😞	2.15% 👍
gdsfactory/export/to_3d.py	49.63% 😞	49.63% 😞	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gdsfactory/components/straight_heater_meander.py	straight_heater_meander	7 ⭐	505 ⛔	28 ⛔	28.10% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/components/grating_coupler_elliptical_arbitrary.py	grating_coupler_elliptical_arbitrary	5 ⭐	403 ⛔	33 ⛔	30.20% 😞	Try splitting into smaller methods. Extract out complex expressions
gdsfactory/export/to_3d.py	to_3d	12 🙂	159 😞	15 😞	42.61% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication