Fixes for issues discovered when serializing dynamic EMF model #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix for issue with custom `java.util.Map$Entry`, used when creating `EMap` - Fix for issue with `org.gecko.emf.converter` used as package name in integration tests Signed-off-by: Michael H. Siemaszko <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue with custom
java.util.Map$Entry, used when creatingEMapOriginal implementation of custom
java.util.Map$Entrywas based on official EMF documentation ( see "EMF/FAQ: How do I create a Map in EMF?" https://wiki.eclipse.org/EMF/FAQ#How_do_I_create_a_Map_in_EMF.3F ), which mentioned that eitherEAttributeorEReferencecan be used.However, using
EReferenceresulted in errors when opening such serializedEcorewith 'Ecore Model Editor'; see attached screenshot (Screenshot from 2024-05-23 04-22-40.png).As it turns out, only using
EAttributeis allowed with customjava.util.Map$Entry, used when creatingEMap.Fix for issue with
org.gecko.emf.converterused as package name in integration testsBoth integration tests, created as part of work on DTO Converters, used
org.gecko.emf.converteras package name in generated dynamic EMF package (org.gecko.emf.converter.tests.DTOToEPackageConverterTest.PACKAGE_NAME,org.gecko.emf.converter.tests.DTOToEObjectConverterTest.PACKAGE_NAME).This resulted in
The name 'org.gecko.emf.converter' is not well formederror when opening such serializedEcorewith 'Ecore Model Editor'Fix for issue with structural features referencing external
eTypeby URIThis issue is pending fix - please see #57 for more details.